New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot use the gradle module plugin with Yubikey or other PKCS11 signing. #41
Comments
Hey Phil, I'm going to have to do some looking before I can commit, but if there's no inherent technical limitation, I'd like to get this done. I'm a bit time strapped at the moment, but will make it a top priority when I've cleared a bit off the old plate (assuming someone else doesn't notice this and beat me to it). Appreciate you pointing out the gap in support, will follow up when I can say something more specific. |
I may beat you to it, then. (I supplied the code Kevin committed to add pkcs11 to the module signer.) |
PRs are always welcome! I'll try and look at this over the next couple days though if you don't beat me to it. I haven't seen the the changes you're mentioning about the signer, where can I find those? KevinH? |
This commit: inductiveautomation/module-signer@7a3df1e |
Oh, I'm following now, thx for the tip - I thought Phil was talking about a more recent change. With that context, it doesn't seem like we'd need an update to the signer dependency at all (and noticed we have some old/outstanding PRs on that lib that prob should get looked at @kevinherron). We'll need to update the SignModule tasks's implementation. Looks like it might just be a minor change in the setup/invocation of the signer around here. Will see if I can get a PR up (or find someone with some time and interest) in the next few days. |
Haven't had time to get to this, but we did open an internal ticket with high priority today to start getting some eyes on this. No timeline/eta, but something that is going to get looked at in the near-term (IGN-7871 is our internal ticket to get this some attention). |
Much appreciated (I've been sidetracked for a few days). |
@pturmel , I'm going to try to take a look at this before the end of the current month (August). 🤞 |
November is the new August. I'm looking at this now. |
Iterating on this in my fork. |
Associated PR merged and |
I would like to migrate to gradle builds (from ant, skipping maven) but the properties for configuring module signing do not support the Module Signer's -pkcs11-cfg option. Is there any chance this can be added?
The text was updated successfully, but these errors were encountered: