Swapped private and public IP?

[julianxhokaxhiu]

Hi,

I'm using your latest version of the package and I found a weirdo issue. Whenever I try to call the .address() API, I get swapped values. See the following snippet:

ip.address( 'private', 'ipv4' ) // 192.168.1.254
ip.address( 'public', 'ipv4' ) // 127.0.0.1

Why? Any help is really appreciated.

Thanks in advance!

[bryanwayb]

Hey @julianxhokaxhiu, good catch. Trouble was backwards logic on an array filter in lib/ip.js, line 388. That code has been like that for at least 3 years, surprised it wasn't caught sooner...

The latests commits have the fix.

[julianxhokaxhiu]

Can you push / Did you push this to NPM?

[bryanwayb]

No, I haven't done a publish.

Hey @indutny, could you do a publish please? I've already incremented the version number.

[indutny]

Done, sorry for delay!

[julianxhokaxhiu]

Thank you!