Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.22.0 vs. zstd 1.5.6 #220

Closed
0-wiz-0 opened this issue Apr 3, 2024 · 1 comment
Closed

0.22.0 vs. zstd 1.5.6 #220

0-wiz-0 opened this issue Apr 3, 2024 · 1 comment

Comments

@0-wiz-0
Copy link

0-wiz-0 commented Apr 3, 2024

When zstd 1.5.6 is installed, building fails with:

gcc -Wsign-compare -DNDEBUG -O2 -g -fstack-clash-protection -I/usr/include -I/usr/pkg/include -O2 -g -fstack-clash-protection -I/usr/include -I/usr/pkg/include -O2 -g -fstack-clash-protection -I/usr/include -I/usr/pkg/include -O2 -g -fstack-clash-protection -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/python3.11 -g -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/python3.11 -fPIC -I/scratch/archivers/py-zstandard/work/zstandard-0.22.0/zstd -I/usr/pkg/include/python3.11 -c build/zstandard/_cffi.c -o build/temp.netbsd-10.99.10-amd64-cpython-311/build/zstandard/_cffi.o
build/zstandard/_cffi.c: In function '_cffi_const_ZSTD_c_experimentalParam6':
build/zstandard/_cffi.c:1512:12: error: 'ZSTD_c_experimentalParam6' undeclared (first use in this function); did you mean 'ZSTD_d_experimentalParam6'?
 1512 |   int n = (ZSTD_c_experimentalParam6) <= 0;
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~
      |            ZSTD_d_experimentalParam6
build/zstandard/_cffi.c:1512:12: note: each undeclared identifier is reported only once for each function it appears in

zstd.h in 1.5.6 has:

     /* was ZSTD_c_experimentalParam6=1003; is now ZSTD_c_targetCBlockSize */

If I replace zstd/zstd.h with the copy from zstd 1.5.6, the build succeeds.
I'm not sure what the right fix is here, any ideas?

@indygreg
Copy link
Owner

The main branch now has support for zstd 1.5.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants