New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non optimised production build? #1804
Comments
Oh I see @jameshulse thanks for pointing out already open tasks for this issue. |
It would be a great addition to fix this issue, reducing bundle size is always good |
Looks like we won't change anything here sorry. |
Can we know the reason at least? |
@RomainLanz Hey! Only reason is for fear of breaking changes...I worry there are going to be subtle differences in the implementation of these that could break existing apps in unexpected ways. Similar suggestions have been made in the past — for example it's been recommended that we use fetch instead of xhr so we can avoid the axios dependency, but what people don't realize is that fetch doesn't support file upload progress. I'd like to replace the lodash dependencies eventually, but do it with some kind of beta release as you suggested in another issue 👍 |
Version:
@inertiajs/vue3
version: ^1.0.0Describe the problem:
Using very bare bones app.js file still triggers googles reduce unused javascript. I have tried a lot of things with vite and I still can't get this issue resolved.
Steps to reproduce:
import { createInertiaApp } from '@inertiajs/vue3';
createInertiaApp({
setup({ el, App, props }) {
});
first is size of app.js and second is savings it could make with removed js code.
…assets/app-06b5762a.js(example-app.test) | 56.8 KiB | 44.1 KiB
Any ideas or any possible way to get this to stop triggering google's page speed warnings?
The text was updated successfully, but these errors were encountered: