Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code polishing #114

Closed
6 tasks done
ineshbose opened this issue Feb 4, 2022 · 2 comments · Fixed by #117
Closed
6 tasks done

Code polishing #114

ineshbose opened this issue Feb 4, 2022 · 2 comments · Fixed by #117
Assignees
@ineshbose
Projects
Block 4

Comments

@ineshbose
Copy link
Owner

ineshbose commented Feb 4, 2022 •
edited

Describe the bug

Provide a clear and concise description of the bug.

There seems to be some code duplication, and style problems at the moment.

Proposed solution

Please provide steps to reproduce the behaviour.

Fix them.

  • Inline styles
  • Code duplication
  • Dependencies
  • Wildcard imports
  • TS as and any
  • Additionally bootstrapping styles (now Bootstrapping styles #116)
@ineshbose ineshbose added this to To do in Block 4 via automation Feb 4, 2022
@ineshbose
Copy link
Owner Author

/cib

@github-actions github-actions bot closed this as completed Feb 4, 2022
Block 4 automation moved this from To do to Supervisor review Feb 4, 2022
@github-actions github-actions bot reopened this Feb 4, 2022
Block 4 automation moved this from Supervisor review to In progress Feb 4, 2022
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Branch issue/114-code_polishing created for issue #114: Code polishing

@ineshbose ineshbose mentioned this issue Feb 7, 2022
Closed
@github-actions github-actions bot mentioned this issue Feb 17, 2022
Merged
@github-actions github-actions bot moved this from In progress to Code review in Block 4 Feb 17, 2022
Block 4 automation moved this from Code review to Supervisor review Feb 17, 2022
@ineshbose ineshbose moved this from Supervisor review to Done in Block 4 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ineshbose ineshbose

Labels
None yet
Projects
Block 4
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code polishing ineshbose/portion-mate
1 participant
@ineshbose