Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a linter to the backend #12

Closed
ineshbose opened this issue Nov 8, 2021 · 2 comments · Fixed by #18
Closed

Add a linter to the backend #12

ineshbose opened this issue Nov 8, 2021 · 2 comments · Fixed by #18
Assignees
Labels
enhancement New feature or request
Projects

Comments

@ineshbose
Copy link
Owner

Is your feature request related to a problem?

Provide a clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Code linting is important for maintenance and review. It's just better practice.

Describe the solution you'd like

Please provide a clear and concise description of what you want to happen.

Adopt Black linting along with a GitHub Action that checks everything to be linted.

Describe alternatives you've considered

Please provide a clear and concise description of any alternative solutions or features you've considered.

Django does not adopt Black traditionally, but a lot of people are still going ahead with it. There are linters for Django as well, but Black blows many out of the water, and also there is previous experience with Black.

@ineshbose ineshbose added the enhancement New feature or request label Nov 8, 2021
@ineshbose ineshbose added this to To do in Block 2 via automation Nov 8, 2021
@ineshbose
Copy link
Owner Author

/cib

@github-actions github-actions bot closed this as completed Nov 9, 2021
Block 2 automation moved this from To do to Supervisor review Nov 9, 2021
@github-actions github-actions bot reopened this Nov 9, 2021
Block 2 automation moved this from Supervisor review to In progress Nov 9, 2021
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

@github-actions github-actions bot moved this from In progress to Code review in Block 2 Nov 9, 2021
Block 2 automation moved this from Code review to Supervisor review Nov 9, 2021
@ineshbose ineshbose moved this from Supervisor review to Done in Block 2 Nov 12, 2021
@ineshbose ineshbose self-assigned this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Block 2
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant