New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glyphs not in line #2
Comments
I confirm the bug. I use this as a temporary fix. \newcommand{\simpleIcon}[1]{%
\raisebox{1.2\fontcharht\font`0}{%
\simpleicon{#1}%
}%
} |
Thank you for confirming the bug and using this package - it means a lot. I'm still investigating for solutions, but I have kept a note for this approach! 😄 |
I think this is a bug with the way the font is constructed. The glyphs are set below the baseline. |
With the aforementioned fix in the font which should be merged soon, the best way to vertical align the icon with the current font is to is to lower the icon by half of the current font depth (taking y as a reference). \newcommand{\simpleIcon}[1]{%
\raisebox{-0.5\fontchardp\font`y}{%
\simpleicon{#1}%
}%
} |
Tracking PR: simple-icons/simple-icons-font#171 Thank you a lot for this. I'm waiting for this to merge, and then from this end I'm intending to fix this from the opentype.js font construction way (https://github.com/ineshbose/simple-icons-latex/blob/master/bindings.js#L31), but at the moment I'm not finding the right methods to do it. With that said, I really appreciate your efforts, and if you would consider making a PR (with the JS approach if feasible else redefining the command) so that your contribution is noted. |
Hi, I don't think you need to do anything on your side. It looks ok without the raisebox. I think this should be done on the font itself glyphs by glyphs as some can look misaligned when lied on the descent line and other if lied on the baseline. If you don't want to wait for the merge, as the font is included in the CTAN package, you can just build the font with the merge applied, copy the otf locally, and |
Thanks for the suggestion! That is definitely one fix along with using the raisebox which one can use temperarily but for the package and developer convenience, it is best that everything is handled by itself without requiring additional configuration or work. I see that the issue has been closed in |
Sorry for taking a while! Package has finally been updated and this is now confirmed to be fix. Thank you very much for your contribution and patience. Closing! |
The character seems to be in the correct position, but the glyphs themselves are appearing below the line.
The text was updated successfully, but these errors were encountered: