convert to net/netip (and thus require Go 1.18+) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
force-pushed
the
bradfitz/netip
branch
3 times, most recently
from
e2231ce
to
8b5da84
Compare
|
Per existing package doc:
So I think it's fair game to break API a bit. |
bradfitz
force-pushed
the
bradfitz/netip
branch
5 times, most recently
from
eb702f7
to
a518089
Compare
Updates tailscale/tailscale#5162 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
danderson
approved these changes
Jul 28, 2022
| "reflect" | ||
| "unsafe" | ||
|
|
||
| "go4.org/netipx" |
There was a problem hiding this comment.
I considered the naming ambiguity a feature, actually. Sweet memories. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tailscale/tailscale#5162