.github/workflows: run on windows-2019 instead of windows-latest #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests used to pass but then started failing because the CI environment changed underfoot. Don't test on "latest". Pin to 2019 explicitly for now until we adjust the tests to be tolerant of 2019 vs 2022, and then we can add CI coverage for both. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
force-pushed
the
bradfitz/winver
branch
from
633ce92
to
6b37121
Compare
maisem
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests used to pass but then started failing because the CI environment
changed underfoot. Don't test on "latest". Pin to 2019 explicitly for now
until we adjust the tests to be tolerant of 2019 vs 2022, and then
we can add CI coverage for both.