Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore "v" prefix from git tags to check for new version #129

Closed
Toilal opened this issue Dec 16, 2020 · 0 comments
Closed

Ignore "v" prefix from git tags to check for new version #129

Toilal opened this issue Dec 16, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Toilal
Copy link
Contributor

Toilal commented Dec 16, 2020 

$ ddb --version
+--------------------------------------------------------------------------------+
|                                   ddb 1.3.0                                    |
+--------------------------------------------------------------------------------+
|                  Please report any bug or feature request at                   |
|          https://github.com/gfi-centre-ouest/docker-devbox-ddb/issues          |
+--------------------------------------------------------------------------------+
|                                                                                |
|                      A new version is available : v1.3.0                       |
|   https://github.com/gfi-centre-ouest/docker-devbox-ddb/releases/tag/v1.3.0    |
| https://github.com/gfi-centre-ouest/docker-devbox-ddb/blob/v1.3.0/CHANGELOG.md |
|                                                                                |
+--------------------------------------------------------------------------------+
@Toilal Toilal added the bug Something isn't working label Dec 16, 2020
@Toilal Toilal closed this as completed in 59d8cd4 Dec 16, 2020
Toilal added a commit that referenced this issue Dec 16, 2020
@Toilal
fix(version): Version check now removes "v" first character from tag (#…
71a3567 
…129)

This avoid version check to always warn a new version is available

Close #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Toilal