Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect manual use of VK_LAYER_RENDERDOC_Capture! #547

Open
Tracked by #533
IAmNotHanni opened this issue Jun 20, 2023 · 0 comments
Open
Tracked by #533

Remove incorrect manual use of VK_LAYER_RENDERDOC_Capture! #547

IAmNotHanni opened this issue Jun 20, 2023 · 0 comments
Labels
cat:dev tools building/ compiling the program, cmake configuration and general development tools prio:low This has low priority.

Comments

@IAmNotHanni
Copy link
Member

Is your feature request related to a problem?

I talked to the creator of RenderDoc (baldurk, Baldur Karlsson) on his Discord and asked if I should use VK_LAYER_RENDERDOC_Capture instance layer manually and he told me not to do this at all. This is used by RenderDoc if you launch the application through RenderDoc. You should never specify this manually. I'm not sure what I was thinking when I wrote this. That means the --renderdoc command line argument will be removed as well.

I would like to thank Baldur Karlsson once again for his overwhelming support every time I ask a question!

Description

This is just incorrect. I don't know what I was thinking.
In my defence, it was for the good though. I wanted to improve debugging experience with it.

Alternatives

There is no point in keeping this at all.
If you want to use RenderDoc for debugging, just launch the application through RenderDoc!

Affected Code

The instance wrapper and application.cpp

Operating System

All

Additional Context

None

@IAmNotHanni IAmNotHanni added cat:dev tools building/ compiling the program, cmake configuration and general development tools prio:low This has low priority. labels Jun 20, 2023
@IAmNotHanni IAmNotHanni mentioned this issue Jun 20, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:dev tools building/ compiling the program, cmake configuration and general development tools prio:low This has low priority.
Projects
None yet
Development

No branches or pull requests

1 participant