Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not clear what to do with MSI for new users #1143

Open
maks-rafalko opened this issue Mar 9, 2020 · 2 comments
Open

It is not clear what to do with MSI for new users #1143

maks-rafalko opened this issue Mar 9, 2020 · 2 comments
Milestone

Comments

@maks-rafalko
Copy link
Member

Feedback from Slack: (dkarlovi)

what I think would do wonders is some actionable information what to do with the MSI number

after having just started using Infection, that wasn't anything to me (since I've never been exposed to MT tools before), it was just some number
what does MSI 30 mean? What does MSI 100 mean?
I didn't know

We need to think about writing an article in our docs that provides comprehensive information about what MSI does mean and how to treat it, what to do next after running Infection.

@sanmai
Copy link
Member

sanmai commented Mar 10, 2020

From Slack:

We have a functional core which deals with things like permission checks, and whether some action is possible given current state.
Methods in the core a purely functional and are thus unit tested (as opposed to integration/functional tests on the rest of the app).
Then we run infection with 100% min MSI, but only over the functional core and only with unit tests.

This is because:

  • It's impossible to get 100% MSI over other parts of the code base
  • Running non-unit tests (ie. with database fixtures and booting Symfony) is waaaaay too slow with xdebug enabled

I think this gives us most of the benefits of infection but without the troubles of identifying which mutants we don't care about and the like.

@maks-rafalko
Copy link
Member Author

Here is what I got in email, pasting as is:

just wanted to share some initial hurdles Im experiencing from a new user perspective.

- wow just ran the command and things happened.. awesome
- hmmm cool lots of red "M"s guess Ill have things to fix
- hmmm whats this json file and how do I view it?
- does it have a coverage viewer like phpunit coverage-html?
- lets run it again with some other options and see what happens to this md file
- hmmm only 2 red Ms now.. did it fix things for me?
- hmmm killed mutants sounds like I killed the bugs.. but docs say its failed tests

Anyways, not really a question.. just thought it would be valuable to share as sometimes when we work on projects for so long we forget what its like to be a new user and thats where the adoption happens.. Im determined to figure out the workflow and how to make my tests stronger.. still not sure how though haha.. i'll keep reading etc

@maks-rafalko maks-rafalko added this to the 0.22.0 milestone Feb 15, 2021
@maks-rafalko maks-rafalko modified the milestones: 0.22.0, 0.23.0 Apr 26, 2021
@maks-rafalko maks-rafalko modified the milestones: 0.23.0, 0.24.0 Jul 3, 2021
@maks-rafalko maks-rafalko modified the milestones: 0.24.0, 0.25.0 Aug 5, 2021
@maks-rafalko maks-rafalko modified the milestones: 0.25.0, next Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants