Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows can't open this file when composer.phar is found #196

Closed
tomzx opened this issue Feb 25, 2018 · 2 comments
Closed

Windows can't open this file when composer.phar is found #196

tomzx opened this issue Feb 25, 2018 · 2 comments
Labels

Comments

@tomzx
Copy link

tomzx commented Feb 25, 2018

Question Answer
Infection version 0.7.1
Test Framework version PHPUnit
PHP version 7.2.1
Platform Windows
Github Repo -

In \Infection\Finder\TestFrameworkExecutableFinder::addVendorFolderToPath, if $this->findComposer() returns the path to a phar file, Windows shows a window asking the user to select which program to use to open the file.

The expected behavior is that it should execute the phar file by calling the php binary since Windows ignores the shebang within the phar file.

It looks like logic from \Infection\Finder\TestFrameworkExecutableFinder::makeExecutable could be reused in order to prefix the phar file with the appropriate php binary.

rundll32_2018-02-24_21-43-27

@sidz sidz added the Bug label Feb 25, 2018
@sidz
Copy link
Member

sidz commented Feb 25, 2018

Good catch 👍 will be covered by #185

@sidz sidz added Has PR and removed Has PR labels Feb 25, 2018
@sidz
Copy link
Member

sidz commented Feb 26, 2018

Fix has been merged.
@tomzx 🚢

@sidz sidz closed this as completed Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants