Infection infects /tmp

[Majkl578]

Question	Answer
Infection version	0.8.2
Test Framework version	PHPUnit 7
PHP version	7.2
Platform	Linux

Infection pollutes /tmp with thousands of files.

$ du -hs /tmp/infection
270M	/tmp/infection
$ ll /tmp/infection | wc -l
18706

This should be cleaned up after run. Otherwise it eats space and RAM (/tmp is typically tmpfs which is RAM-based).

[maks-rafalko]

Probably, it should be configurable since we reuse created mutants to avoid extra IO operations

infection/src/Mutant/MutantCreator.php

Lines 71 to 76 in 2276560

	private function createMutatedCode(MutationInterface $mutation, string $mutatedFilePath): string
	{
	if (file_exists($mutatedFilePath)) {
	return file_get_contents($mutatedFilePath);
	}
	$traverser = new NodeTraverser();

On the other side, I'm not sure many people will run infection many times in a row

[theofidry]

It should definitely be cleaned up after a run I agree.

The issue (and it's the same as in XdebugHandler, cf. composer/xdebug-handler#50) is that it's not easy to cleanup when interrupting the command.

Once thing that could be done however is create the temporary files in a infection directory of the temporary directory and clean it up at the start of the run (to be careful that it won't affect/collide with the one used for XdebugHandler)

[sidz]

Once thing that could be done however is create the temporary files in a infection directory of the temporary directory and clean it up at the start of the run (to be careful that it won't affect/collide with the one used for XdebugHandler)

We can't guarantee that user didn't change tmpDir between infection execution. IMO we need to clean tmpDir after a run.

[theofidry]

I don't think the user should change it neither rely that it won't change.

That said it might be an issue with concurrent runs

[maks-rafalko]

fixed #357