Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC pass/fail indicator #115

Open
cooperthompson opened this issue Feb 24, 2022 · 2 comments
Open

TOC pass/fail indicator #115

cooperthompson opened this issue Feb 24, 2022 · 2 comments

Comments

@cooperthompson
Copy link

In each sequence you have nice big green checkmarks for passes:
image

But in the TOC view, you just have little dots:
image

However, it doesn't look like the dot color lines up with the "sum" or the tests.

See this test session:
https://inferno-dev.healthit.gov/onc-certification-g10-test-kit/test_sessions/94395c64-b6e2-4a22-b8f5-c0285b2e85dd#g10_certification-g10_smart_standalone_patient_app-smart_standalone_launch

All the tests in the Standalone Patient App sequence passed, but the TOC summary shows fail:
image

Also, making the TOC pass/fail indicator more of a checkmark / x icon instead of just a colored dot would be nice. I'm red/green color blind :).

@arscan
Copy link
Contributor

arscan commented Feb 28, 2022

Also, making the TOC pass/fail indicator more of a checkmark / x icon instead of just a colored dot would be nice. I'm red/green color blind :).

Absolutely, thank you for identifying this issue for us.

However, it doesn't look like the dot color lines up with the "sum" or the tests.

Yes, this is broken, but maybe in a different way than you think. It is an issue with putting the user in the wrong view unexpectedly. We are redirecting the user to a view that encompasses just sub-step 2 of the 'Standalone Patient App' group during the oauth handoff. Which is very confusing because our UI doesn't let you normally navigate to sub-steps in g10 certification. If you click on the nav item on the left for 'Standalone Patient App' you'll see all steps presented on a single view.

We'll fix that asap. Thanks!

This was referenced Feb 28, 2022
@arscan
Copy link
Contributor

arscan commented Mar 2, 2022

Both of these issues should be resolved in the version now deployed on https://inferno-dev.healthit.gov/

Screen Shot 2022-03-02 at 1 19 27 PM

Note that the link that provided in your report still looks wrong, because it is reporting the result of just step 2 in the 'Single Patient App' set of tests. With this update, you won't ever be sent to that substep, and instead would be sent here after the launch.

Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants