Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined method `warning' for Logger:0x0000561690c6b180 Did you mean warn? #228

Open
kayadanae opened this issue Jul 22, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@kayadanae
Copy link

kayadanae commented Jul 22, 2022

ONC recently removed a test from Tab 6 of the g.10 test suite. Following this change, the input json file we had historically used contained inputs that Inferno no longer recognized. When trying to run the tests, our POST to https://inferno.healthit.gov/suites/api/test_runs was met with a 500 and the following response: {"errors":"undefined method 'warning' for #\u003cLogger:0x0000561690c6b180\u003e\nDid you mean? warn"}.

I believe this is coming from this line of code.

We updated our json to remove the no longer used inputs and are now seeing tests pass normally so this is non-blocking/non-urgent on our end, just wanted to report this little bug since I imagine others may run into it following the recent change as well.

@Jammjammjamm Jammjammjamm added the bug Something isn't working label Jul 25, 2022
@Jammjammjamm
Copy link
Collaborator

Thanks, we'll take care of that. Itshould be warn rather than warning.

@arscan
Copy link
Contributor

arscan commented Jul 25, 2022

We also need to document when inputs change in the release notes of a test kit (g10 in this case)... you shouldn't have to discover that through warnings in the log. FYI @Jack-Fraser16. Thanks @kayadanae!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants