Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 Syntax Error #61

Closed
andrewlphilpott opened this issue Feb 15, 2018 · 9 comments
Closed

IE11 Syntax Error #61

andrewlphilpott opened this issue Feb 15, 2018 · 9 comments
Labels

Comments

@andrewlphilpott
Copy link

I'm probably just missing something, but I just tried running a new app created with create-inferno-app in IE11 and I'm getting a syntax error. It looks like it’s because of the arrow function in inferno-dev-utils/node_modules/ansi-regex/index.js:

module.exports = () => {
	const pattern = [
		'[\\u001B\\u009B][[\\]()#;?]*(?:(?:(?:[a-zA-Z\\d]*(?:;[a-zA-Z\\d]*)*)?\\u0007)',
		'(?:(?:\\d{1,4}(?:;\\d{0,4})*)?[\\dA-PRZcf-ntqry=><~]))'
	].join('|');

	return new RegExp(pattern, 'g');
};

Do I need to add a polyfill or something to get this to work in IE11?

@Havunen
Copy link
Member

Havunen commented Feb 15, 2018

hmm, that seems to be third party module, used only in development.

@Havunen
Copy link
Member

Havunen commented Feb 15, 2018

I guess production build works fine?

@andrewlphilpott
Copy link
Author

andrewlphilpott commented Feb 15, 2018

@Havunen I assume so, but I haven't tried running it yet.

@Havunen Havunen added the bug label Feb 15, 2018
@andrewlphilpott
Copy link
Author

@Havunen Yep, the production build is fine. Probably not a huge deal since it's just development but it may make browser testing a little more cumbersome for anybody needing to support IE11 and down.

@Havunen
Copy link
Member

Havunen commented Mar 6, 2018

Maybe we should refactor that third party out of this library?

@LukeSheard
Copy link

@andrewlphilpott I could imagine that it’s due to a webpack config setting that means node modules aren’t processed by Babel in development but are in production.

@farooqkz
Copy link

As IE has been obsolete, I think this issue is not valid anymore.

@Havunen
Copy link
Member

Havunen commented Dec 9, 2023

IE11 is not officially supported anymore.

@Havunen Havunen closed this as completed Dec 9, 2023
@farooqkz
Copy link

@Havunen You had to close it as invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants