-
-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components do not respond to changes in the mobx stores #1199
Comments
I have a similar issue. But more precice. The update seems to be delayed for one update cycle. Tracetable, for example:
Edit: I was wrong. |
Can you guys create jsFiddle or similar test case to reproduce it please |
After inspecting the dist of inferno-mobx, it seems like we have a problem with this build. The makeReactive function is empty, maybe an issue with rollup?:
|
thats very possible, rollup was updated between these versions |
Yup, this was caused by rollup upgrade. They changed tree shaking algorithm and caused this bug. I will downgrade rollup and make new release. |
Its fixed now in 3.8.2 but lets keep this bug open for reference |
I really appreciate that the issue is found. I struggle a bit with the jsfiddle example. Here is what I have: https://jsfiddle.net/1kf4ftzc/8/ Currently it doesn't work because. 😞 I am still figuring it out. But assuming all the needed functions where available, this would be a fiddle. :) |
0.49.2 fixed some more regressions, btw. |
Ideally we should run our tests against the bundle we ship. Currently however we run the tests against typescript sources compiled by typescript compiler, but rollup is not part of this process. Also debugging is really difficult at the moment and I had to fork |
Closing this issue now as rollup has fixed it in 0.49.3 |
After I upgraded to 3.8.1 from 3.7.1, my components stopped responding to changes in the mobx stores. Why did it happen?
The text was updated successfully, but these errors were encountered: