Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document inferno-router #1607

Closed
Coachonko opened this issue Sep 4, 2022 · 2 comments · Fixed by infernojs/inferno-website#166
Closed

Document inferno-router #1607

Coachonko opened this issue Sep 4, 2022 · 2 comments · Fixed by infernojs/inferno-website#166

Comments

@Coachonko
Copy link

Currently the website links to the react router documentation, third party documentation is not perfectly matching current inferno-router functionality (hooks missing, native support missing though mentioned), furthermore it may be taken down at any time since react-router v5 is old and soon unmaintained

It would be best to mirror the docs for now, edit and publish them on the Inferno website later.

@Havunen
Copy link
Member

Havunen commented Sep 4, 2022

Yeah thats true, was there something specific what you were looking for? Did you find the information? Is it something you could maybe add to the inferno router documentation?

@Coachonko
Copy link
Author

Coachonko commented Sep 5, 2022

Yeah thats true, was there something specific what you were looking for? Did you find the information? Is it something you could maybe add to the inferno router documentation?

The fact that the hooks are not implemented is not mentioned, not difficult to find out but I think all differences should be mentioned when referencing a third-party document. I think these small issues are hurting adoption, particularly now that Inferno is diverging from React more and more

The technique documented in react-router v5 to give specific classes to inactive NavLink does not seem to work, I'm seeking help in the discord to confirm whether it is the intended behavior or not first, but nobody has replied on discord yet.

<NavLink
  to="/faq"
  className={isActive =>
    "nav-link" + (!isActive ? " nounderline" : "")
  }
>
  FAQs
</NavLink>

results in

<a class="function className(isActive) {
      return &quot;nav-link&quot; + (!isActive ? &quot; no-underline&quot; : &quot;&quot;);
    }" aria-current="false" href="/faq">FAQs</a>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants