Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify visibility? #26

Closed
christopherarter opened this issue Oct 15, 2018 · 5 comments
Closed

Specify visibility? #26

christopherarter opened this issue Oct 15, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@christopherarter
Copy link

Hi there,

Great package!

Question: Is there a way to specify the visibility when saving a file? e.g.
Storage::put('file.jpg', $contents, 'public');

I notice it looks like it's defaulted to public here:
https://github.com/InfinetyES/Nova-Filemanager/blob/f7176a2e6f2148d174533dc91f3bbc4551db23e5/src/Http/Services/FileManagerService.php#L222

Thank you!

@lwiml
Copy link

lwiml commented Nov 27, 2018

Do you have any solution yet, or workaround?

@christopherarter
Copy link
Author

@lwiml Not quite, I ended up having to edit that method, setting the default to private. Then, if I wanted to show a file publicly I used signed Urls to authorize the file to be accessed.

@lwiml
Copy link

lwiml commented Nov 28, 2018

@christopherarter thanks, im familiar with signedUrls. Hope this will be fixed soon in the package for other users.

@Krato
Copy link
Collaborator

Krato commented Dec 10, 2018

Hi @christopherarter. Not yet. May be in the future

@Krato Krato added the enhancement New feature or request label Dec 10, 2018
@Krato
Copy link
Collaborator

Krato commented Mar 11, 2019

Hello @christopherarter. You can set he visibility now with v2. Please check the readme. Regards

@Krato Krato closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants