Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #668: Cover store/sessions.js with tests #718

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

SazukinPavel
Copy link
Contributor

No description provided.

@SazukinPavel SazukinPavel requested a review from a team February 14, 2024 09:59
@SazukinPavel SazukinPavel self-assigned this Feb 14, 2024
@SazukinPavel SazukinPavel linked an issue Feb 14, 2024 that may be closed by this pull request
Copy link
Contributor

@slntopp slntopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing with:

 FAIL  tests/store/plugins.test.js [ tests/store/plugins.test.js ]
Error: [🍍]: "getActivePinia()" was called but there was no active Pinia. Are you trying to use a store before calling "app.use(pinia)"?
See https://pinia.vuejs.org/core-concepts/outside-component-usage.html for help.
This will fail in production.
 ❯ Module.useStore node_modules/.pnpm/pinia@2.1.7_vue@3.4.15/node_modules/pinia/dist/pinia.mjs:1709:19
 ❯ src/store/namespaces.js:12:18
     10| import { createConnectTransport } from "@connectrpc/connect-web";
     11| 
     12| const appStore = useAppStore();
       |                  ^
     13| 
     14| export const useNSStore = defineStore("namespaces", {
 ❯ src/store/plugins.js:2:31

PLEASE RUN TESTS BEFORE SUBMITTING PR

Copy link

Coverage Report for ./console

Status Category Percentage Covered / Total
🔵 Lines 8.32% 654 / 7857
🔵 Statements 8.32% 654 / 7857
🔵 Functions 13.2% 14 / 106
🔵 Branches 39.81% 43 / 108
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
console/src/store/accounts.js 10.95% 100% 100% 10.95% 24-218
Generated in workflow #932

@SazukinPavel SazukinPavel merged commit a6d1402 into dev-store-tests Feb 20, 2024
3 of 4 checks passed
@SazukinPavel SazukinPavel deleted the dev-cover-store-sessions-with-tests branch February 20, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover store/sessions.js with tests
2 participants