Bug : Marshaller type error in getCache() (and FIX)

[sharefeel]

Two overloaded getCache() have bug.

----------------- BUGGY FUNCTION ----------------------

1. template <class K, class V> RemoteCache<K, V> getCache(
   HR_SHARED_PTR<Marshaller > km, HR_SHARED_PTR<Marshaller > vm,
   bool forceReturnValue = false)
2. template <class K, class V> RemoteCache<K, V> getCache(
   HR_SHARED_PTR<Marshaller > km, HR_SHARED_PTR<Marshaller > vm,
   const std::string& name, bool forceReturnValue = false)

----------------- BUG LINE ----------------------
rcache.valueMarshallerPtr.reset(new portable::counted_wrapper<HR_SHARED_PTR<Marshaller > >(vm), &genericDelete);

Ths line sets user-given marshaller function of VALUE.
And type of VALUE is template parameter "V"
But, key type "K" is used instead of "V".

----------------- FIX ----------------------
"K" ---> "V"
rcache.valueMarshallerPtr.reset(new portable::counted_wrapper<HR_SHARED_PTR<Marshaller > >(vm), &genericDelete);

[sharefeel]

The code of bug line is not pasted properly.

Anyway, shortly, type of VALUE marshaller's template parameter has to be set as "V" not "K".

[rvansa]

Thanks for finding out. Anyway, don't use those two methods (use those with directly shared marshaller pointer and destructor) - these are provided only for compatibility with previous version which had serious problems with ABI compatibility.

[ghost]

Thank you for the bug report and fix. Moving the issue over to the JBoss issue tracking system at https://issues.jboss.org/browse/HRCPP-177.