ISPN-4471 MapReduceTask: memory leak with useIntermediateSharedCache #2693
Conversation
| Cache<KOut, VOut> sharedTmpCache = cm.getCache(intermediateCache); | ||
| if (sharedTmpCache != null && allMapPhasesResponses != null) { | ||
| for (KOut k : allMapPhasesResponses) { | ||
| sharedTmpCache.remove(new IntermediateCompositeKey<KOut>(taskId.toString(), k)); |
There was a problem hiding this comment.
maybe removeAsync? you don't need to wait the reply right?
There was a problem hiding this comment.
Right, I don't. Good point. Although I think the accompanying test here that checks how tmp cache was indeed cleared might fail. Will see what can do.
There was a problem hiding this comment.
hmmm right... So, if you don't find a solution, it is better to keep it synchronous, otherwise the test suite is going to bite us later :P
|
@pruivo update PR according to your feedback! Thanks again |
|
@pruivo I kept removeAsync as there are probably only a few values in this particular test. It seems to work locally after repeated trials. Let's see what CI says |
|
the CI looks good. testing and pushing... |
|
integrated! thanks @vblagoje ! |
Master only. See https://issues.jboss.org/browse/ISPN-4471 for more details