ISPN-13470 Ldap UserPasswordCredentialLoaderBuilder shouldn't be added by default #9986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolovison
force-pushed
the
ldap_backport
branch
from
79d1118
to
494f4a5
Compare
tristantarrant
requested changes
Mar 21, 2022
| @@ -11,7 +11,7 @@ | |||
| * @since 10.0 | |||
| */ | |||
| public class LdapUserPasswordMapperConfiguration extends ConfigurationElement<LdapUserPasswordMapperConfiguration> { | |||
| static final AttributeDefinition<String> FROM = AttributeDefinition.builder(Attribute.FROM, "userPassword", String.class).immutable().build(); | |||
| static final AttributeDefinition<String> FROM = AttributeDefinition.builder(Attribute.FROM, null, String.class).immutable().build(); | |||
There was a problem hiding this comment.
Leave the default as-is. The only alternative that I know of is Active Directory, which uses sAMAccountName, but you cannot use that for evidence verification (only direct verification is possible).
| builder.setUserPasswordAttribute(attributes.attribute(FROM).get()); | ||
| if (!attributes.attribute(VERIFIABLE).get()) { | ||
| builder.disableVerification(); | ||
| if (attributes.attribute(FROM).get() != null) { |
There was a problem hiding this comment.
I think the better option here is to add the usercredentialbuilder by default if direct-evidence-verification is false in LdapRealmConfiguration.
|
Our credentials were removed from the LDAP server. I will work on this PR once they have been recreated. |
|
I've made the changes myself in #9983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/ISPN-13470