JDF-412 get jdf repo modifications

[rafabene]

Before moving JDG to git submodule, we need to get all modifications from JDF repo. This modifications are present in this PR.

• The readme path was updated to consider the git submodule folder (one more level).
• The header and source code format (some files) was updated to match https://github.com/jboss-jdf/jboss-as-quickstart/blob/master/CONTRIBUTING.md
• The properties was updated to match https://docspace.corp.redhat.com/docs/DOC-135368
• The version were also update to 6.1.0 which is the latest JDG version. (focus on products)

[rafabene]

Can you provide a tag after merging this PR? Thanks

[mgencur]

Hi Rafael, I've got a few comments.

1. Do we really need to include the ASL 2.0 in every single file? For instance, these license headers were recently removed from Infinispan project and there's only one reference to the license in the whole project.
2. There are a lot of formatting changes, some of them changing indentation from 3 to 4 spaces. Was this intended? In Infinispan/JDG, we use 3-space indentation.
3. About the change of version to 6.1.0-SNAPSHOT....How about changing it to 6.2.0-SNAPSHOT? The point is that 6.1.0 was already released and when there's a SNAPSHOT in x.y.z-SNAPSHOT version of the project, the next release will be x.y.z, not x.(y+1).z

Thanks
Martin

[rafabene]

I'll check 1 and 2 with @pmuir but that is an little answer why it was changed.

1. I don't know how this applies to Infinispan project. But for JDF it was added after since it is part of contributing guide and QSTools checked for it: https://github.com/jboss-jdf/jboss-as-quickstart/blob/master/CONTRIBUTING.md#license-information-and-contributor-agreement

2. Same for JDF Contribuiting guide that defines https://github.com/jboss/ide-config as the standard

3. +1 to use 6.2.0-SNAPSHOT - I'll update the PR after we define 1) and 2)

[pmuir]

1. It's best practice to include license headers in all files, AIUI from Red Hat legal.
2. 4 spaces is the Java standard, and the JBoss standard, so I think this would be better.
3. Agreed.

[pmuir]

Otherwise looks good.

[mgencur]

OK. I take you points.

[rafabene]

Updated the version to 6.2.0-SNAPSHOT

Thanks

[rafabene]

Btw. I'd like to include it on jdf-site 2.1.6 that will be release 07/23.

It should be a great help with you merge and tag it today so I can have this on next release. Thanks

[mgencur]

Integrated.

[mgencur]

Still need to create the tag.