Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta generate history - generated way too much history #1206

Closed
Puckfist opened this issue Jan 23, 2018 · 1 comment
Closed

Meta generate history - generated way too much history #1206

Puckfist opened this issue Jan 23, 2018 · 1 comment

Comments

@Puckfist
Copy link
Contributor

The history generation code in the MetaEditDwr recently gained deletion code that reveals a willingness to log interval points all the way from 1970. The cause of this interval logging is that the simulation timer was advancing to the start time, not simply being set to start at the start time and then advancing to the end time. Specifically, line 308 of MetaEditDwr is

simTimer.fastForwardTo(from);

while it could be

simTimer.setStartTime(from);

We should evaluate if this fast forward (which has been around since at least Mango 2.5) had a purpose.

@Puckfist
Copy link
Contributor Author

If this is to be done, one would think one may wish to set the simulation timer's start time before initializing the interval logging for the historical data point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant