Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct typespec for response type #45

Merged

Conversation

sambou
Copy link

@sambou sambou commented Oct 1, 2018

This PR fixes a faulty typespec in the main module. The response type should be a union type.

@coveralls
Copy link

coveralls commented Oct 1, 2018

Coverage Status

Coverage remained the same at 97.99% when pulling 1349004 on sambou:fix/response-typespec into 4d1ba74 on infinitered:master.

@danielberkompas
Copy link
Owner

Looks good, thanks! The test failure looks like a coveralls.io timeout, nothing related to this change. ⭐ ⭐ ⭐

@danielberkompas danielberkompas merged commit 7fefb28 into danielberkompas:master Oct 1, 2018
@danielberkompas
Copy link
Owner

I released a new version containing this change: 0.5.3.

@sambou
Copy link
Author

sambou commented Oct 2, 2018

Yeah 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants