Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default commands have unpruned params #123

Closed
GantMan opened this issue Dec 18, 2016 · 4 comments
Closed

Default commands have unpruned params #123

GantMan opened this issue Dec 18, 2016 · 4 comments

Comments

@GantMan
Copy link
Member

GantMan commented Dec 18, 2016

As violent delights have violent ends, so do default commands have unpruned params
-- Dolores

running ignite add ui gives parameters.first the value of "default"
image

This looks like some leakage.

馃憴 Bikini Bonus:
Would be helpful to have parameters.last - which is how I plan on fixing this for futureproof ways. But I'm not a fan of that method.

@skellock
Copy link
Contributor

Ya, I agree, something seems off about parameters.

parameters gets rewritten because i'm trying to target the plugin/command.

I'm up for changing this.

@skellock
Copy link
Contributor

I think what's bothering me about this is its confusing arguments (things that exist on the command line) with arguments (things that get fed into a command). I think we can probably clear this up with a conversation.

@jamonholmgren
Copy link
Member

If we do change this, maybe we should use a different property to stay backwards compatible? Maybe that's a horrible idea but I have parameters.second strewn all over my code.

@skellock
Copy link
Contributor

skellock commented Oct 1, 2017

This has completely reworked in 2.0

@skellock skellock closed this as completed Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants