Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted plugin namespaces #61

Closed
skellock opened this issue Dec 10, 2016 · 2 comments
Closed

Restricted plugin namespaces #61

skellock opened this issue Dec 10, 2016 · 2 comments
Assignees
Milestone

Comments

@skellock
Copy link
Contributor

skellock commented Dec 10, 2016

Prevent these namespaces from being defined in 3rd party plugins:

  • spork
  • project
  • gluegun
  • default

If we see those namespaces, we should just go into a badnamespace error state on the plugin.

@skellock skellock added this to the Beta 1 milestone Dec 10, 2016
@skellock
Copy link
Contributor Author

After a good sleep:

spork - This is the first core-plugin. Something isn't quite sitting right with me here. I can't put my finger on it.

project - Yup, no problem. The project namespace represents access to the project-based plugin in the ./gluegun directory.

gluegun - I'm not sure why I added this to the list. spork is it's own namespace.

default - I'm not sure why I added this either.

So, for sure, let's add project, but jury is out on the other ones.

spork would cause a collision if someone made a plugin called spork. Or if someone made a command called spork in branded mode. But if we have a collision disambiguation feature, this wouldn't be an issue.

So let's make project reserved, and revisit the others later.

@skellock
Copy link
Contributor Author

#64

@skellock skellock self-assigned this Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant