Update new template #734
Update new template #734
Conversation
No more need for ts-jest
Inline bash command are not working on windows.
| @@ -124,7 +124,7 @@ const NewCommand: GluegunCommand = { | |||
|
|
|||
| const target = | |||
| `${props.name}/` + | |||
| (props.language === 'typescript' && file.includes('.js.ejs') | |||
| (props.language === 'typescript' && file.includes('.js.ejs') && !file.startsWith('.') | |||
There was a problem hiding this comment.
This is to avoid .eslintrc.js to be convert into a typescript file
| @@ -0,0 +1,20 @@ | |||
| /** | |||
| * @type {import("eslint").Linter.Config} | |||
There was a problem hiding this comment.
This is to have autocomplete on the eslint config (very practicle 😀 )
| @@ -1,4 +1,8 @@ | |||
| const { system, filesystem } = require('gluegun') | |||
| <% if (props.language === "typescript") { %> | |||
| import { system, filesystem } from 'gluegun' | |||
There was a problem hiding this comment.
eslint was not happy with require syntax and this is more natural in a typescript setup
| "clean-build": "rm -rf ./build", | ||
| "compile": "tsc -p .", | ||
| "copy-templates": "if [ -e ./src/templates ]; then cp -a ./src/templates ./build/; fi", | ||
| "build": "yarn format && yarn lint && yarn clean-build && yarn compile && yarn copy-templates", | ||
| "copy-templates": "copyfiles ./src/templates/* ./build/templates", |
There was a problem hiding this comment.
Do the exact same but in a cross-platform version (I'm working on windows 🙄)
|
On CI: Locally: I guess I was just not lucky regarding the timeout 😕 |
|
@jamonholmgren Can you help me on this failing CI? Not really sure why this is taking so much time… |
|
@fabien0102 I apparently missed this PR, apologies. I'll be looking at it soon! |
|
Can you push a new empty commit to this to restart the CI and see if it passes? |
I can, but will be tomorrow, no computer around ;) (but I think I already tried... But with a bit of luck 🤞) |
|
@jamonholmgren The CI is still failing… |
|
This has taken me way too long to get to, @fabien0102, but it looks amazing. I'll be publishing a new version this week. |
# [5.0.0](v4.7.1...v5.0.0) (2022-01-21) ### Bug Fixes * **deps:** Pin colors to 1.3.3 ([#745](#745) by [@otaviopace](https://github.com/otaviopace)) ([c33f24f](c33f24f)), closes [#744](#744) * **deps:** Updates cli-table, cosmiconfig, ejs, execa, and fs-jetpack ([#741](#741) by [@jamonholmgren](https://github.com/jamonholmgren)) ([ee9d84a](ee9d84a)) ### Features * **boilerplate:** New CLI template includes eslint and better Windows support ([#734](#734) by [@fabien0102](https://github.com/fabien0102)) ([627bcb8](627bcb8)) ### BREAKING CHANGES * **deps:** Updates cli-table, cosmiconfig, ejs, execa, and fs-jetpack major (breaking) versions * Also updates other dependencies to minor or patch versions
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #737
Hello,
First of all, very nice project, this looks really amazing and I can't wait to try this framework on my projects 😁
This said, the
newtemplate looks a bit out-of-date, so this is my little contribution to this projectWhat's inside?
copyfilesto be able to build the project on a windows machinehusky&pretty-quickto format on pre-commitimportinstead ofrequireon typescript project (so eslint is happy)How to test
gluegun newand runyarn testgluegun newand runyarn test/yarn build