Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump ejs to 3.1.8 #764

Merged

Conversation

bennetthardwick
Copy link
Contributor

Currently when installing a CLI created with gluegun users will see a message saying "1 critical severity vulnerability" because of a vulnerability in ejs: GHSA-phwq-j96m-2c2q

1661753952

While it's not likely this will cause an issue it might worry some people who install gluegun created CLIs.

This vulnerability is patched in ejs@3.1.7 so bumping the version will get rid of this message.

@@ -47,7 +47,7 @@
"@typescript-eslint/eslint-plugin": "^4.17.0",
"@typescript-eslint/parser": "^4.17.0",
"ts-jest": "^26.5.3",
"ts-node": "^9.1.1",
"ts-node": "^10.9.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamonholmgren this is a fix for the issue with CI happening in #763 (and all PRs I think). Let me know and I can split it out if you like.

@yulolimum
Copy link
Member

@jamonholmgren we'll want to get this merged soon as it resolves issues on a freshly spun-up project.

yulolimum-capture-2022-09-03--19-43-33

@ravenastar-js
Copy link

If possible, update ejs to version 3.1.7 or higher as it is causing problems with windows powershell, by default powershell blocks execution of dependencies that have vulnerability and using script to bypass execution of vulnerable dependencies is not good for system security. thanks for the attention and compression 💜
unknown

@ThomasDRT
Copy link

Looking to see if we can get this merged and closed as well. We've got some workarounds in place but are looking forward to getting the vulnerability properly addressed. Thanks!

@Mashbourne1
Copy link

Same here. Awaiting the fix for this vulnerability as well. Thanks much in advance!

@danstepanov
Copy link

while ejs is no longer a dependency, the change to ts-node resolves this issue for me, thanks

@jamonholmgren
Copy link
Member

Hey everyone, sorry about the long delay on this. Finally getting to cleanup of all PRs and issues.

@jamonholmgren jamonholmgren merged commit be2433b into infinitered:master Sep 28, 2023
3 checks passed
infinitered-circleci pushed a commit that referenced this pull request Sep 28, 2023
## [5.1.6](v5.1.5...v5.1.6) (2023-09-28)

### Bug Fixes

* **deps:** bump ejs to 3.1.8 ([#764](#764) by [@bennetthardwick](https://github.com/bennetthardwick)) ([be2433b](be2433b))
@infinitered-circleci
Copy link

🎉 This PR is included in version 5.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants