Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Project tests fail if I18n plugin is not included #13

Closed
ericvera opened this issue Apr 4, 2017 · 4 comments
Closed

Project tests fail if I18n plugin is not included #13

ericvera opened this issue Apr 4, 2017 · 4 comments
Labels
bug

Comments

@ericvera
Copy link
Contributor

ericvera commented Apr 4, 2017

boilerplate/Tests/Setup.js has a reference to I18n.
@GantMan
Copy link
Member

GantMan commented Apr 4, 2017

awesome! Will fix. Would you like to give it a go first?

PRs welcome!

@GantMan GantMan added the bug label Apr 4, 2017
@ericvera
Copy link
Contributor Author

ericvera commented Apr 4, 2017

Working on the move to Jest at the moment. I'll let you know if I get to it before somebody else. This is mostly an issue when testing plugins with --min option so not urgent. If other people see this I can take a look sooner.

@ruddell
Copy link
Contributor

ruddell commented Apr 7, 2017

This is the same issue as infinitered/ignite#911

I submitted a PR on the 2016 boilerplate infinitered/ignite-ir-boilerplate-2016#20

@jamonholmgren
Copy link
Member

I'm working on a port of that over to here. THanks @ruddell for fixing this!

@jamonholmgren jamonholmgren mentioned this issue Apr 21, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GantMan @jamonholmgren @ruddell @ericvera