Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

RN 0.63 and navigation 4.0.0 #309

Merged
merged 5 commits into from
Jul 24, 2020
Merged

Conversation

SandeshVakale
Copy link
Contributor

No description provided.

Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jamonholmgren
Copy link
Member

@SandeshVakale Do you know why the tests are failing in CI? Do they pass locally?

Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI

@SandeshVakale
Copy link
Contributor Author

Hello @jamonholmgren , I changed node version. now test are passed. If you have any other changes, let me know. Else you can Merge my pull request. thanks

@jamonholmgren jamonholmgren merged commit c979162 into infinitered:master Jul 24, 2020
@DeVoresyah
Copy link

@SandeshVakale thanks for updating to RN 0.63
I've a question about the navigation, does react-navigation v5 still not stable so we just stay at version 4?

infinitered-circleci pushed a commit that referenced this pull request Jul 24, 2020
# [4.3.0](v4.2.0...v4.3.0) (2020-07-24)

### Features

* **boilerplate:** Updates to RN 0.63 and React Navigation 4.0.0 ([#309](#309) by @SandeshVakale) ([c979162](c979162))
@infinitered-circleci
Copy link

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jamonholmgren
Copy link
Member

Great job @SandeshVakale !

@SandeshVakale
Copy link
Contributor Author

thanks @jamonholmgren

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants