Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Update tsconfig settings #376

Merged
merged 4 commits into from
Sep 28, 2020
Merged

Update tsconfig settings #376

merged 4 commits into from
Sep 28, 2020

Conversation

fvonhoven
Copy link
Contributor

Closes #201

Description:

  • Update bowser's tsconfig.json settings to match this commit.

@jamonholmgren
Copy link
Member

Looks like CircleCI is failing?

@fvonhoven
Copy link
Contributor Author

fvonhoven commented Sep 25, 2020 •
edited
Loading

So, it seems we are compiling with TS at the moment...
yarn compile runs tsc -p
Screen Shot 2020-09-25 at 1 22 38 PM
image

and it appears that noEmit is not going to work in that case
https://stackoverflow.com/questions/55002137/typescript-noemit-use-case
image

@jamonholmgren jamonholmgren merged commit 6b4d66e into master Sep 28, 2020
@jamonholmgren jamonholmgren deleted the 201-latest-tsconfig branch September 28, 2020 17:39
infinitered-circleci pushed a commit that referenced this pull request Sep 28, 2020
@semantic-release-bot
chore(release): 5.4.1 [skip ci]
4d39a91 
## [5.4.1](v5.4.0...v5.4.1) (2020-09-28)

### Bug Fixes

* **typescript:** Update tsconfig settings ([#376](#376) by [@fvonhoven](https://github.com/fvonhoven)) ([6b4d66e](6b4d66e))
@infinitered-circleci
Copy link

🎉 This PR is included in version 5.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamonholmgren jamonholmgren Awaiting requested review from jamonholmgren

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure tsconfig has the latest and greatest IR preferences
3 participants
@fvonhoven @jamonholmgren @infinitered-circleci