Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Standard JS linting #76

Closed
GantMan opened this issue Oct 18, 2017 · 0 comments
Closed

Add Standard JS linting #76

GantMan opened this issue Oct 18, 2017 · 0 comments

Comments

@GantMan
Copy link
Member

GantMan commented Oct 18, 2017

The code in here is Standard JS compliant, but we have no standard checker for the CI. Someone should simply add Standard to the lib test command so it is enforced by CI on all PRs.

// Enforcing JS tests
https://github.com/standard/standard

// Enforcing TS files

// Comments ok in TS JSON files
// I'm the `tslint.json 
{
  "extends": "tslint-config-standard"
  // Option to modify standard if we want
  // "rules": {
  //   "trailing-comma": [true, {"multiline": "always", "singleline": "never"}]
  // }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant