Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scoping option #15

Closed
dingo-d opened this issue Jul 15, 2019 · 2 comments · Fixed by #77
Closed

Add scoping option #15

dingo-d opened this issue Jul 15, 2019 · 2 comments · Fixed by #77
Assignees
Labels
research This is not and issue but and improvement that needs research
Milestone

Comments

@dingo-d
Copy link
Collaborator

dingo-d commented Jul 15, 2019

We should probably add this everywhere in libs (or maybe just here and in boilerplate).

It's a lib to prevent namespace issues in the dependencies.

https://deliciousbrains.com/php-scoper-namespace-composer-depencies/

@iruzevic iruzevic self-assigned this Nov 6, 2019
@iruzevic iruzevic modified the milestones: v2.0.2, v2.0.3 Nov 6, 2019
@MetarDev
Copy link
Contributor

MetarDev commented Jan 9, 2020

This should definitely be added once we get boilerplate working as a plugin (when it will be a real possibility that a user has a theme and 2-3 plugins installed created using boilerplate, all possibly using different version of https://github.com/infinum/eightshift-libs

@MetarDev MetarDev added this to To do in eightshift-libs Jan 9, 2020
@iruzevic iruzevic added research This is not and issue but and improvement that needs research and removed enhancement labels May 12, 2020
@iruzevic iruzevic changed the title Add php-scoper as a dependency Add scoping option Jul 19, 2020
@iruzevic iruzevic modified the milestones: v2.0.3, v3.0.0 Jul 19, 2020
@iruzevic iruzevic linked a pull request Jul 19, 2020 that will close this issue
@iruzevic
Copy link
Member

done

eightshift-libs automation moved this from To do to Done Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research This is not and issue but and improvement that needs research
Projects
Development

Successfully merging a pull request may close this issue.

3 participants