Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] - Abstract main enable PHPDI caching for other enviroments not only production or staging #393

Closed
iruzevic opened this issue Apr 26, 2024 · 1 comment
Assignees
Labels
feature request New feature request improvement Small improvement fixes, either readability or performance improvements

Comments

@iruzevic
Copy link
Member

We have something like:

if (\defined('WP_ENVIRONMENT_TYPE') && (\WP_ENVIRONMENT_TYPE === 'production' || \WP_ENVIRONMENT_TYPE === 'staging')) {
			$file = \explode('\\', $this->namespace);

			$builder->enableCompilation(__DIR__ . '/Cache', "{$file[0]}CompiledContainer");
		}

We need to make this configurable by providing a function that allows overriding the cached environments list from the project.

@iruzevic iruzevic added the feature request New feature request label Apr 26, 2024
@iruzevic iruzevic self-assigned this Apr 26, 2024
@iruzevic iruzevic linked a pull request Apr 27, 2024 that will close this issue
@iruzevic iruzevic added the improvement Small improvement fixes, either readability or performance improvements label Apr 28, 2024
@iruzevic
Copy link
Member Author

iruzevic commented Jun 5, 2024

this is done in the latest release

@iruzevic iruzevic closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature request improvement Small improvement fixes, either readability or performance improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant