Feature/demo v2 #15
Merged
Feature/demo v2 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgulan
approved these changes
Jun 8, 2018
| @@ -24,7 +24,8 @@ final class LoginViewController: UIViewController { | |||
|
|
|||
| @IBOutlet private weak var loginButton: UIButton! | |||
| @IBOutlet private weak var loginButtonBottomMargin: NSLayoutConstraint! | |||
|
|
|||
| @IBOutlet weak var registerButton: UIButton! | |||
|
|
||
| // MARK: Private | ||
|
|
||
| private func registerForKeyboardNotifications() { |
There was a problem hiding this comment.
Use underscore for private funcs,
Truba
requested changes
Jun 8, 2018
| @@ -52,6 +53,10 @@ final class LoginViewController: UIViewController { | |||
| ) | |||
| } | |||
|
|
|||
| @IBAction func registerButtonActionHandler() { | |||
| @IBAction func registerButtonActionHandler() { | ||
| presenter.didSelectRegisterAction() | ||
| } | ||
|
|
||
| @IBAction func tapGestureRecognizerActionHandler() { |
| private var _interactor: RegisterInteractorInterface | ||
| private var _wireframe: RegisterWireframeInterface | ||
|
|
||
| private let _authorizationManager = AuthorizationAdapter.shared |
There was a problem hiding this comment.
It's a better practise to inject this things.
|
|
||
| // MARK: Actions | ||
|
|
||
| @IBAction func registerButtonActionHandler() { |
| presenter.didSelectRegisterAction(with: usernameTextField.text, email: emailTextField.text, password: passwordTextField.text, confirmedPassword: confirmPasswordTextField.text) | ||
| } | ||
|
|
||
| @IBAction func tapGestureRecognizerActionHandler() { |
| view.endEditing(true) | ||
| } | ||
|
|
||
| @IBAction func closeButtonActionHandler() { |
| ) | ||
| } | ||
|
|
||
| @objc func keyboardWillShow(_ notification: Notification) { |
| } | ||
| } | ||
|
|
||
| @objc func keyboardWillHide(_ notification: Notification) { |
fgulan
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.