[Merged by Bors] - feat: Retry monitoring if there is a failure #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galibey
reviewed
Feb 9, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
Also add error logs if there is an issue.
Right now,
```
while let Some(stream) = incoming.next().await {
let mut stream = stream?;
```
could finish if there is an error like broken pipe,
```
2023-02-09T17:56:39.649123Z ERROR fluvio_spu::monitoring: error running monitoring: Broken pipe (os error 32)
```
This adds changes to retry to create the unix socket if there is a failure
sehz
approved these changes
Feb 9, 2023
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add error logs if there is an issue.
Right now,
could finish if there is an error like broken pipe,
This adds changes to retry to create the unix socket if there is a failure