Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(cdk): added target info on cdk publish #3075

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat(cdk): added target info on cdk publish #3075

wants to merge 1 commit into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Mar 13, 2023 •
edited

Fixes #3068

@galibey galibey self-assigned this Mar 13, 2023
@galibey galibey requested review from sehz and digikata March 13, 2023 17:23
@galibey galibey added this to the 0.10.6 milestone Mar 13, 2023
digikata
digikata approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved

Not a blocker, but a follow on change may be to add a tag into the published package metadata w/ e.g. ("target", "aarch64-unknown-linux-musl")

sehz
sehz approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galibey
Copy link
Contributor Author

galibey commented Mar 13, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 13, 2023
feat(cdk): added target info on cdk publish (#3075)
f619f59 
Fixes #3068
@bors
Copy link

bors bot commented Mar 13, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(cdk): added target info on cdk publish [Merged by Bors] - feat(cdk): added target info on cdk publish Mar 13, 2023
@bors bors bot closed this Mar 13, 2023
@galibey galibey deleted the feat/3068-add-target-to-cdk-publish branch March 14, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

@sehz sehz sehz approved these changes

Assignees

@galibey galibey

Labels
None yet
Projects
None yet
Milestone
0.10.6
Development

Successfully merging this pull request may close these issues.

Add Target support to cdk publish
3 participants
@galibey @digikata @sehz