[Merged by Bors] - feat(cdk): supply arch tag on publish if not set
#3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digikata
reviewed
Mar 16, 2023
| @@ -498,6 +507,27 @@ pub fn package_verify_with_readio<R: std::io::Read + std::io::Seek>( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn augment_arch(package_meta: &mut PackageMeta, target: Option<&str>) { | |||
There was a problem hiding this comment.
Shouldn't augment_arch just accept a target instead of Option. Why call it at all if target is None? Or is this a useful pattern? Thinking about this because we may other optional package tags in the future...
There was a problem hiding this comment.
Indeed, moving a if outside and making augment_arch accept target looks nicer. I changed it. Thanks.
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
The presence of `arch` tag is required for multi-arch packaging. If it is not specified in `package-meta.yaml` we supply it before publishing (to be precise, before the package assembling).
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Mar 20, 2023
The presence of `arch` tag is required for multi-arch packaging. If it is not specified in `package-meta.yaml` we supply it before publishing (to be precise, before the package assembling).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
arch tag on publish if not setarch tag on publish if not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of
archtag is required for multi-arch packaging. If it is not specified inpackage-meta.yamlwe supply it before publishing (to be precise, before the package assembling).