Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: use relative paths in generated package-meta #3123

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - fix: use relative paths in generated package-meta #3123

wants to merge 3 commits into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Apr 7, 2023

Fixes #3119

@galibey galibey requested review from digikata and sehz April 7, 2023 13:05
@galibey galibey self-assigned this Apr 7, 2023
@galibey galibey added DX/SMDK DX/CDK Connector Developer Kit labels Apr 7, 2023
@digikata
Copy link
Contributor

digikata commented Apr 7, 2023 •
edited

Can you add a "publish --pack" step to the smdk smoke tests for regression coverage?

In tests/cli/smdk_smoke_tests/smdk-basic.bats add something like the following as a last step for at least one test case:

    run $SMDK_BIN publish --pack
    assert_success

@galibey
Copy link
Contributor Author

galibey commented Apr 7, 2023

It turned out that in smdk cli tests the crate is inside the workspace. This case wasn't supported by smdk publish. So I added this support in the same way as it is done for cdk publish.

digikata
digikata approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM

@sehz
Copy link
Contributor

sehz commented Apr 7, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 7, 2023
fix: use relative paths in generated package-meta (#3123)
b7e6de8 
Fixes #3119
@bors
Copy link

bors bot commented Apr 7, 2023

Pull request successfully merged into master.

Build succeeded:

  • Done

@bors bors bot changed the title fix: use relative paths in generated package-meta [Merged by Bors] - fix: use relative paths in generated package-meta Apr 7, 2023
@bors bors bot closed this Apr 7, 2023
@galibey galibey deleted the fix/3119-relative-paths-in-default-package-meta branch April 8, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

@sehz sehz sehz approved these changes

Assignees

@galibey galibey

Labels
DX/CDK Connector Developer Kit DX/SMDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative paths in auto-generated package-meta in cdk and smdk tools
3 participants
@galibey @digikata @sehz