Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - docs: example of aggregation sm with initial value #3126

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - docs: example of aggregation sm with initial value #3126

wants to merge 2 commits into from

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Apr 10, 2023

Fixes #3121

@galibey galibey requested a review from sehz April 10, 2023 15:37
@galibey galibey self-assigned this Apr 10, 2023
sehz
sehz requested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of nits

smartmodule/examples/aggregate-init/Cargo.toml Outdated
@@ -0,0 +1,14 @@
[package]
name = "fluvio-wasm-aggregate-init"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's name more exact. Like sm-integer-sum-aggegrate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

smartmodule/examples/aggregate-init/SmartModule.toml Outdated Show resolved Hide resolved
smartmodule/examples/aggregate-init/transforms.yaml Outdated Show resolved Hide resolved
sehz
sehz approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galibey
Copy link
Contributor Author

galibey commented Apr 10, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 10, 2023
docs: example of aggregation sm with initial value (#3126)
6a59f0e 
Fixes #3121
@bors
Copy link

bors bot commented Apr 10, 2023

Build failed:

@galibey
Copy link
Contributor Author

galibey commented Apr 10, 2023

bors retry

bors bot pushed a commit that referenced this pull request Apr 10, 2023
docs: example of aggregation sm with initial value (#3126)
8fbd0a5 
Fixes #3121
@bors
Copy link

bors bot commented Apr 10, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title docs: example of aggregation sm with initial value [Merged by Bors] - docs: example of aggregation sm with initial value Apr 10, 2023
@bors bors bot closed this Apr 10, 2023
@galibey galibey deleted the feat/3121-example-aggragate-with-init branch April 10, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz approved these changes

Assignees

@galibey galibey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

example: Aggregate with init
2 participants
@galibey @sehz