Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: introduce zstd compression #3185

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat: introduce zstd compression #3185

wants to merge 2 commits into from

Conversation

EstebanBorai
Copy link
Contributor

Introduces the ZSTD Compression algorithm for Fluvio Compression Crate.

Related: #2268

@EstebanBorai
Copy link
Contributor Author

CI issues look related to: gyscos/zstd-rs#93
Found: https://github.com/gyscos/zstd-rs/wiki/Compile-for-WASM

@EstebanBorai EstebanBorai linked an issue Apr 23, 2023 that may be closed by this pull request
zstd compression algorithm support #2268
Closed
@EstebanBorai
Copy link
Contributor Author

Looks like partition wasn't available for the assertion when test ran, re arranged.

# -- output does not contain substring --
[483](https://github.com/infinyon/fluvio/actions/runs/4780777986/jobs/8498755978?pr=3185#step:16:484)
# substring : qw-qu4k-ZSTD
[484](https://github.com/infinyon/fluvio/actions/runs/4780777986/jobs/8498755978?pr=3185#step:16:485)
# output    : Partition not found: owww-dl-0
[485](https://github.com/infinyon/fluvio/actions/runs/4780777986/jobs/8498755978?pr=3185#step:16:486)
# --

morenol
morenol reviewed Apr 24, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@EstebanBorai EstebanBorai force-pushed the 2268-zstd-compression branch 2 times, most recently from 6adb704 to 9d8bcf8 Compare May 4, 2023 16:17
@EstebanBorai EstebanBorai mentioned this pull request May 4, 2023
Closed
@EstebanBorai EstebanBorai requested a review from morenol May 16, 2023 22:34
@morenol
Copy link
Contributor

morenol commented May 17, 2023 •
edited

@EstebanBorai I see this warning while trying to compile from this branch:

warning: /Users/morenol/infinyon/fluvio/crates/fluvio-compression/Cargo.toml: version requirement `0.12.3+zstd.1.5.2` for dependency `zstd` includes semver metadata which will be ignored, removing the metadata is recommended to avoid confusion

Seems like a crates.io issue
gyscos/zstd-rs#62

morenol
morenol approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EstebanBorai
Copy link
Contributor Author

bors r+

bors bot pushed a commit that referenced this pull request May 17, 2023
@EstebanBorai
feat: introduce zstd compression (#3185)
c8315c1 
Introduces the ZSTD Compression algorithm for Fluvio Compression Crate.

Related: #2268
@bors
Copy link

bors bot commented May 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: introduce zstd compression [Merged by Bors] - feat: introduce zstd compression May 17, 2023
@bors bors bot closed this May 17, 2023
@EstebanBorai EstebanBorai mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morenol morenol morenol approved these changes

@sehz sehz Awaiting requested review from sehz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zstd compression algorithm support
2 participants
@EstebanBorai @morenol