Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a different file for tests updating the config #3708

Merged

Conversation

matheus-consoli
Copy link
Contributor

@matheus-consoli matheus-consoli commented Nov 15, 2023

We have a problem when a test fails intermittently to read the config file.

Most tests only read the config file, but one is also modifying it, so I changed it so that the test has its own config file.

I'm not entirely sure that this solves the issue. I've run the CI a couple of times after the changes, and it didn't fail once, but that could be just luck.

fixes: #3707

@matheus-consoli matheus-consoli added this pull request to the merge queue Nov 16, 2023
Merged via the queue into infinyon:master with commit 84d95d0 Nov 16, 2023
104 checks passed
@matheus-consoli matheus-consoli deleted the fix-intermittent-test branch November 16, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo test config::config::test::test_config intermittently fails in CI
2 participants