Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce MAX BYTES for transferring batch records #38

Closed
sehz opened this issue Jun 2, 2020 · 1 comment · Fixed by #71
Closed

Enforce MAX BYTES for transferring batch records #38

sehz opened this issue Jun 2, 2020 · 1 comment · Fixed by #71

Comments

@sehz
Copy link
Contributor

sehz commented Jun 2, 2020

Fluvio uses zero copy I/o to transfer records from SPU to client.
Records to need to be limit since maximum bytes can be up to 1G for each segment.

Solution:

  • SPU: Limit transferring file slice. This will create potentially truncated last batch
  • Kf decoder: When decoding DefaultRecords, ignore any batch that can't be decoded
  • Client: Use offset in the last batch to retrieve next batches for streaming cases
  • SPU-SPU: Apply spu-message-size to limit bytes
@sehz sehz added API CLI Client StreamController Streaming Controller SPU SPU related and removed StreamController Streaming Controller labels Jun 2, 2020
@sehz sehz modified the milestones: 1.00-beta, 1.00-Alpha Jun 2, 2020
@sehz sehz linked a pull request Jun 15, 2020 that will close this issue
@sehz
Copy link
Contributor Author

sehz commented Jun 15, 2020

Everything except item 3 is implemented. That will be done as part of Issue #72 (new client API)

@sehz sehz closed this as completed Jun 15, 2020
@sehz sehz self-assigned this Jun 15, 2020
@sehz sehz modified the milestones: 1.0.0-alpha, 1.0.0-alpha-oss-1 Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant