Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fvm): list included artifacts with fvm list <channel> #3877

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented Feb 23, 2024

Introduces support to list versions of artifacts used in a FVM channel/version.

Given that currently FVM doesn't keeps track of installed artifacts, for previous versions
users are prompted to reinstall the version in order to update this data.

Demo

demo.mp4

Screenshot

Listing artifacts headers

CleanShot 2024-02-23 at 19 44 13@2x

@EstebanBorai EstebanBorai linked an issue Feb 23, 2024 that may be closed by this pull request
@digikata
Copy link
Contributor

I like that it has a way of resolving older fvm data sets. Nice!

I updated the issue out from under you a little and added report the current channel & version info on the first line so if we ask a user to run this, it's all contained in the output. Artifacts in channel "stable" version "0.11.4" I'm not sure about the formatting, if you have a better suggestion I'd go with it.

@ajhunyady
Copy link
Contributor

This looks great! Nice work @EstebanBorai

@EstebanBorai EstebanBorai marked this pull request as ready for review February 23, 2024 22:58
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EstebanBorai EstebanBorai added this pull request to the merge queue Feb 24, 2024
Merged via the queue into infinyon:master with commit 0609deb Feb 24, 2024
109 checks passed
@EstebanBorai EstebanBorai deleted the 3876-fvm-list-pkgset-should-list-artifact-versions-in-that-package-set branch February 24, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fvm list <CHANNEL> should list artifact versions in that channel
3 participants