fix: improve kubectl access errors #3895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacardin
reviewed
Mar 11, 2024
| #[arg(long)] | ||
| use_k8_port_forwarding: bool, | ||
|
|
||
| /// Uses port forwarding for connecting to SC during install | ||
| /// Uses ip for connecting to SC (only during install) |
There was a problem hiding this comment.
This is for the case where this crate is running inside the same k8 cluster as the installation target
There was a problem hiding this comment.
Seems pretty narrow. Should I just remove the text between parens and hide it by default?
digikata
force-pushed
the
kubectl-access-error-pre
branch
from
76dc734
to
d30263c
Compare
nacardin
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.