Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): add docker compose example #3910

Merged
merged 6 commits into from
Mar 22, 2024
Merged

chore(examples): add docker compose example #3910

merged 6 commits into from
Mar 22, 2024

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented Mar 21, 2024 •
edited

Demo

Screen.Recording.2024-03-21.at.8.21.16.PM.mov

@EstebanBorai EstebanBorai marked this pull request as ready for review March 21, 2024 23:24
@digikata
Copy link
Contributor

nice writeup!

@digikata digikata self-requested a review March 21, 2024 23:33
@EstebanBorai EstebanBorai added this pull request to the merge queue Mar 21, 2024
digikata
digikata reviewed Mar 21, 2024
View reviewed changes
examples/docker-compose/README.md

## Running Locally

Clone this repo using `git clone https://github.com/infinyon/fluvio.git` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need to add mkdir metadata data. This makes it so starting back up retains both the metadata state and the data of the compose cluster.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker takes care of creating them! I prefixed with fluvio- in the user side to avoid conflicts with local dirs!

@EstebanBorai EstebanBorai removed this pull request from the merge queue due to a manual request Mar 21, 2024
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@EstebanBorai
chore(examples): add docker compose example (#3910)
8c9d0d8 
* chore(examples): add docker compose example

* feat: readme with instructions

* fix: rm justfile
@EstebanBorai
Copy link
Contributor Author

Testing produce/consume from a fresh Fluvio install!

Screenshot 2024-03-21 at 21 57 42

digikata
digikata approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EstebanBorai EstebanBorai added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit 85b5ea1 Mar 22, 2024
102 checks passed
@EstebanBorai EstebanBorai deleted the chore/docker-example branch March 22, 2024 01:39
@ajhunyady
Copy link
Contributor

Nice work @EstebanBorai, I like the trick with running the command line to register to SPU. Awesome!
Can you please send a pull request to the docs in InfinyOn Website as well?

@EstebanBorai
Copy link
Contributor Author

Nice work @EstebanBorai, I like the trick with running the command line to register to SPU. Awesome!

Can you please send a pull request to the docs in InfinyOn Website as well?

Hi @ajhunyady!

Kudos to @digikata as well as we worked on this together!

Sure! An update on the documentation is in the works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EstebanBorai @digikata @ajhunyady