Make it possible to regenerate bindgen work

[palfrey]

Currently this is hardcoded as https://github.com/infinyon/node-bindgen/blob/master/nj-sys/src/binding.rs with no docs/build.rs to redo it. It either needs some instructions on how to regenerate it, or ideally it gets rebuilt at build time.

[sehz]

I will remove generated code from check-in. Will use build.rs to generate them at compile them.

[sehz]

Unfortunately, bindgen requires installation of LLVM which adds burden for developer. I will update instruction on how to regenerate manually at least.

[sehz]

nj-sys crate now contain Makefile to re-generate binding.rs. let me know if this doesn't work

[palfrey]

After doing brew install llvm and export PATH=/usr/local/opt/llvm/bin:$PATH I was able to run make generate successfully. However my binding.rs appears to be about half the size (38857 bytes vs. 60720). A copy of that is available at https://gist.github.com/palfrey/390e099f16c6774faa9063afa11829b7. Any ideas why the difference?

[sehz]

What version of LLVM are you using? Existing binding.rs was generated using 9.0.0.1. When I tried using latest version 10.0, only difference is a single line with NAPI_VERSION. Also bindgen version is 0.52.

From looking at your binding.rs, it seems be missing Darwin pthread.

pub type __darwin_mbstate_t = __mbstate_t;
pub type __darwin_ptrdiff_t = ::std::os::raw::c_long;
pub type __darwin_size_t = ::std::os::raw::c_ulong;
pub type __darwin_va_list = __builtin_va_list;
pub type __darwin_wchar_t = ::std::os::raw::c_int;
pub type __darwin_rune_t = __darwin_wchar_t;
pub type __darwin_wint_t = ::std::os::raw::c_int;
pub type __darwin_clock_t = ::std::os::raw::c_ulong;
pub type __darwin_socklen_t = __uint32_t;
pub type __darwin_ssize_t = ::std::os::raw::c_long;
pub type __darwin_time_t = ::std::os::raw::c_long;
pub type __darwin_blkcnt_t = __int64_t;
pub type

Not sure if they are important. You can test binding.rs by running example test. Also be sure to generate binding.rs by

make generate

[palfrey]

Last version I had installed with homebrew, which turns out to be 6.0.0. Probably worth documenting the version of LLVM used to generate binding.rs then?

[sehz]

done. README.md updated with LLVM requirement

[palfrey]

Retried with more modern LLVM. LGTM.

[sehz]

closing